databricks-cli: switch to replit/databricks-cli fork#482
Draft
luketchang wants to merge 1 commit intomainfrom
Draft
databricks-cli: switch to replit/databricks-cli fork#482luketchang wants to merge 1 commit intomainfrom
luketchang wants to merge 1 commit intomainfrom
Conversation
cdeb15b to
e1bd3c7
Compare
Point the databricks-cli module at the Replit fork at github.com/replit/databricks-cli, branch replit-main (commit 4928653c). The fork tracks upstream v0.290.2 + 1 Replit commit, which adds --concurrency and --retry-timeout flags to `databricks sync` to mitigate 502s and let us tune in-flight request count when deploying Apps from pid2. Pinning to v0.290.2 (the same release nixpkgs is on) keeps the test skip list identical to nixpkgs upstream's, so the build matches established practice. Bumping past v0.291.0 in a future PR will require adding skip entries for the new SDK host-metadata resolver tests; that's a separate change. Slack thread: https://replit.slack.com/archives/C0A2Z9042FR/p1778082184841149 ~ written by Zerg 👾 ([wp-7918444a](https://zerg.zergrush.dev/chat?id=wp-7918444a))
e1bd3c7 to
6b2b35a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pid2's
databricks.tsinvokesdatabricks syncto upload Repl files to a Databricks Apps workspace. We've been hitting 502s mid-sync that surface as fatal errors because the upstream SDK's retry predicate covers 429/504 but not 502/503. We also want the option to dial in-flight upload concurrency.The fork at
replit/databricks-cliadds two flags todatabricks sync(anddatabricks bundle sync):--retry-timeout(default 30s) — per-call deadline for retrying transient gateway errors (HTTP 502/503/504), implemented with the SDK'sretries.Poll.--concurrency(default 5) — replaces the hardcoded 20 in-flight request limit.Fork branch: https://github.com/replit/databricks-cli/tree/replit-main
Upstream PR (merged): replit/databricks-cli#1
Slack thread: https://replit.slack.com/archives/C0A2Z9042FR/p1778082184841149
What changed
srcfromdatabricks/cliv0.286.0 →replit/databricks-clireplit-mainat commit4928653c. The branch is upstreamv0.290.2+ the 1 Replit commit. Version string is0.290.2-replit-4928653c.hashandvendorHash. Vendor hash is identical to nixpkgs' v0.290.2 entry (the Replit commit doesn't add new Go dependencies).meta.homepageto the fork; keepmeta.changelogpointing at upstream tags.checkFlagsskip list stays identical to nixpkgs', mirroring established practice. v0.291+ adds an SDK host-metadata resolver that's awkward to test in the nix sandbox; bumping past it is a separate change.Test plan
135 test packages run in the nix sandbox during
nix build, includinglibs/sync(covers the new retry helper) andcmd/sync(covers the new flags). 0 failures. ThecheckFlagsskip list is unchanged from the original PR (#477) and mirrors nixpkgs upstream.Rollout
The new flags have sane defaults, so existing callers (pid2's
databricks sync ...invocation) get the new retry behaviour and concurrency=5 automatically without any pid2 change. To revert, change the pin back to upstreamdatabricks/cliv0.286.0 with the original hashes.Revertibility
Safe to revert. Pure module pin change with no migrations or persistent state.
~ written by Zerg 👾 (wp-7918444a)